Fixing notebook and adding jupyter

Shulk97 commented 4 years ago

Fixed various problems concerning notebooks from packages Feature Visualisation and Building Block such as code remaining in Python 2 or bugs occurring in the save and load functions of the package misc.io. Adding of Jupyter versions of several notebooks that are meant to be used on the user's machine for his own model. It includes widgets in order to be easy to use.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

Shulk97 commented 4 years ago

The Jupyter notebooks are placed in a folder "jupyter_versions" in each package folder. Currently it is only the case for building-blocks (notebooks/building-blocks).

I forgot to list the other features of my PR :

adding of a new notebook "SpritemapGenerator.ipynb" which allow the user to generate spritemaps for his own model. (placed in notebooks/building-blocks/jupyter_versions)
adding of a module showing how to import a Keras model in Lucid (keras_model_import_example.py in lucid/recipes/)
adding of a module showing how do define a custom model like the models from modelzoo (custom_model.py in lucid/misc/custom_model.py)
adding of a new notebook "misc_objectives.ipynb" show further examples of objectives. (placed in notebooks/feature-visualization )

ludwigschubert commented 3 years ago

Hi @Shulk97 ! Wow, that's quite a PR; so sorry for ignoring it for so long! I'd still be happy to merge all of these, but since I'm about a year late, I'd need you to rebase on master first. Since your PR comes from a fork, I don't think I can do so for you.

Once you've rebased I hope tests should pass again, and then I'd be happy to merge. Thank you for your contributions! Once they're merged, we should think about how to signpost them to future users; e.g. I think we could add some of your sample notebooks to the public README if you're up for it?

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Shulk97 commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

memo Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google/docs/cla/#troubleshoot)).

* The email used to register you as an authorized contributor must be the email used for the Git commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).

* The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).
information_source Googlers: Go here for more info.

@googlebot I signed it!

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Shulk97 commented 3 years ago

Hello @ludwigschubert ! Thank you for your reply I would be happy to contribute to Lucid. The tests are passing again thanks to the rebase, however it seems that the consent of some authors of the rebased commits is missing. Could you see which consents are missing ?

If my pull request is accepted I could then propose an update of the README taking account of my contributions.

ludwigschubert commented 3 years ago

Hi @Shulk97 ! I've run into that issue before; I just wish the bot would point us to the offending commits! (It's likely just a stray email address.)

I'll take a look on Monday (it's EOD in my time zone already) and take it from here; thanks for updating!

PS: Agree that we should add them to the reader; if you already want to prepare: see if you want to make a thumbnail like we have done for the other notebooks? (But no pressure!)

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tensorflow / lucid