search

tensorflow / metadata

Utilities for passing TensorFlow-related metadata between tools
Apache License 2.0
106 stars 49 forks source link

Loosen abseil version requirement for Python 3.8 support #10

Closed lgeiger closed 4 years ago

lgeiger commented 4 years ago

Abseil < 0.9 isn't compatible with Python 3.8. This PR loosens the version requirements since it would break compatibility with Python 3.8 and reintroduce https://github.com/tensorflow/tensorflow/issues/35027

It looks like abseil is only used for testing (b338be67d97cd186d7ebb2c4034d714c7954d534), so alternatively this dependency could be removed entirely and only added to the test dependencies.

/cc @mihaimaruseac

mihaimaruseac commented 4 years ago

Let's increase minbound of abseil to 0.9

lgeiger commented 4 years ago

Let's increase minbound of abseil to 0.9

Changed in 618b4790031b86eb6ad1a8ea087ddea8773f3c7f

mihaimaruseac commented 4 years ago

@jay90099 could you get someone to approve this please?

jay90099 commented 4 years ago

Sure adding @caveness from TFMD , @caveness could you please approve it ?

dhruvesh09 commented 4 years ago

Thank You @lgeiger, absl-py version has been loosened in order to support py3.8 . Please let us know if you face any issues.

lgeiger commented 4 years ago

Thank You @lgeiger, absl-py version has been loosened in order to support py3.8 . Please let us know if you face any issues.

@dhruvesh09 Is there a timeline for a new release with these changes?