search

tensorflow / metadata

Utilities for passing TensorFlow-related metadata between tools
Apache License 2.0
106 stars 49 forks source link

Update the protobuf dependency? #37

Open NeilGirdhar opened 2 years ago

NeilGirdhar commented 2 years ago

Could the protobuf dependency be incremented by two major versions please?

chhabrakadabra commented 2 years ago

To make a case for this ticket, many libraries are now requiring protobuf>4. Meaning that tensorflow-metadata is blocking codebases from upgrading all these other libraries.

mattb-zip commented 1 year ago

it looks like this is holding us back from upgrading to tensorflow 2.12.0 and using protobuf 4 for any use case that requires tensorflow-metadata, or tensorflow-datasets which requires tensorflow-metadata

coreyhu commented 1 year ago

any word on this?

elgalu commented 1 year ago

any updates?

NeilGirdhar commented 12 months ago

@rtg0795 Would you mind taking a look at this?

masonkirchner commented 11 months ago

Any updates on this?

EDIT: If you could publish any changes that loosen the Protobuf dependency as tensorflow-metadata==1.14.1 that would be appreciated. A 1.15.0 release with the loosened Protobuf dependency would be worthless without re-releasing all the Tensorflow libraries that depend on tensorflow-metadata because they're all scoped to tensorflow-metadata<1.15.0.

rtg0795 commented 10 months ago

@NeilGirdhar Hi. I see that 'protobuf>=3.20.3,<4.21' has been used for 1.14.0. Can you please explain or provide more details on why this is not sufficient?

NeilGirdhar commented 10 months ago

@rtg0795 I'll let others comment more on this, but if I remember, this was preventing upgrades to Python 3.12. See also: https://github.com/tensorflow/metadata/issues/37#issuecomment-1263995064 and https://github.com/tensorflow/metadata/issues/37#issuecomment-1491387336

NeilGirdhar commented 8 months ago

@rtg0795 What are your thoughts? It's been almost two years since this was requested.

jeffpicard commented 7 months ago

@rtg0795 protobuf>=3.20.3,<4.21 is not sufficient because 4.21 is the first released 4.x version.

This is blocking us as well.

NeilGirdhar commented 7 months ago

Thank you for fixing this on master! For everyone watching this, we just need to wait for the next release or use the master version.

Also, just noting that Protobuf 5 is now out :smile:

rclough commented 2 months ago

Is this fixed on master? The boundary is still <4.21, which does not include any valid protobuf 4 versions. This is impacting my organization as well. We have packages that depend on protobuf >4, and the current boundary does not provide that.

Note: This is for Py39/310, the newer protobuf versions are supported for py311, but note even TFX supports 311 yet/we will probably need 39/310 support for a while anyways