Allow dialect to create friendly names for block arguments

jbruestle commented 5 years ago

Provide a callback similar to getOpResultName but for block arguments.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

River707 commented 5 years ago

Please make sure that you sign the CLA.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jbruestle commented 5 years ago

Thanks for the comments, think I fixed everything.

flaub commented 4 years ago

I'm in the process of updating this PR. Part of the challenge is that every time we move LLVM/MLIR forward, we also need to move our BUILD files forward (we also use bazel). How does your team manage this? Is the process to have a separate cmake environment and then transition to bazel? Vice versa?

River707 commented 4 years ago

Internally at google we maintain both separately+simultaneously. If it helps your team, the TensorFlow copy of the MLIR BUILD files can be viewed at: https://github.com/tensorflow/tensorflow/blob/master/third_party/mlir/BUILD

flaub commented 4 years ago

Yep we use that one (and the autogenerated LLVM one), thanks! (but we have to make some tweaks to both of them so that they work outside of tensorflow :) )

jbruestle commented 4 years ago

Updated version submitted by @flaub, closing.

tensorflow / mlir