search

tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.73k stars 257 forks source link

SmallVector->SmallVectorImpl #247

Closed tjingrant closed 4 years ago

tjingrant commented 4 years ago

LLVM ProgrammersManual indicates that SmallVectorImpl is preferred over SmallVector. Conforming to the manual may be a good idea.

joker-eph commented 4 years ago

I took liberty to rewrite the commit message to "Use SmallVectorImpl instead of SmallVector for function parameters (NFC)" when landing, hope you won't mind!

tjingrant commented 4 years ago

@joker-eph thanks! Not at all. Will take note to write better commit messages next time!