search

tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.73k stars 257 forks source link

Make isValidSymbol more powerful #252

Closed bondhugula closed 4 years ago

bondhugula commented 4 years ago

The check in isValidSymbol, as far as a DimOp result went, checked if the dim op was on a top-level memref. However, any alloc'ed, view, or subview memref would be fine as long as the corresponding dimension of that memref is either a static one or was in turn created using a valid symbol in the case of dynamic dimensions.

Reported-by: Jose Gomez

Signed-off-by: Uday Bondhugula uday@polymagelabs.com

nicolasvasilache commented 4 years ago

Blocked by #254, fix is in flight.

nicolasvasilache commented 4 years ago

Fix has landed, please rebase and I'll push it internally (may be some delay this is the first time I try this part of the flow).

bondhugula commented 4 years ago

Anything more here? The build is failing due to an issue unrelated to this PR.