[spirv] Add a canonicalizer for `spirv::LogicalNotOp`. - Githubissues

tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure

1.73k stars 257 forks source link

[spirv] Add a canonicalizer for `spirv::LogicalNotOp`. #256

Closed denis0x0D closed 4 years ago

denis0x0D commented 4 years ago

This PR addresses https://github.com/tensorflow/mlir/issues/165

Adds a canonicalizer for spirv::LogicalNotOp. Converts:

spv.LogicalNot(spv.IEqual(...)) -> spv.INotEqual(...)
spv.LogicalNot(spv.INotEqual(...)) -> spv.IEqual(...)
spv.LogicalNot(spv.LogicalEqual(...)) -> spv.LogicalNotEqual(...)
spv.LogicalNot(spv.LogicalNotEqual(...)) -> spv.LogicalEqual(...)

Also moved the test for spv.IMul to arithemtic tests.

@antiagainst @MaheshRavishankar can you please take a look? Thanks!