search

tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.73k stars 257 forks source link

Failed CI commit merged to master #274

Closed clementval closed 4 years ago

clementval commented 4 years ago

Seems like the last few commits merged to the master branch today (Nov 25) did not succeed the CI but where merged anyway. Is that expected? I see some tests failing as well on my machine (macOS) with the latest master.

Screen Shot 2019-11-26 at 10 00 57 AM

nicolasvasilache commented 4 years ago

Some path seems to have changed, looking. Can you confirm that you see 2 errors related to the mlir-cpu-runner tests?

clementval commented 4 years ago

@nicolasvasilache Yes just modifying the path to the libs fixes the two tests (remove the mlir-cpu-runner directory in the RUN line for the mlir-cpu-runner/utils.mlir and mlir-cpu-runner/linalg_integration_test.mlir tests.

nicolasvasilache commented 4 years ago

Thanks, the problem here is the mismatch between the path that Google internal tools use and OSS. I reverted the offending PR in 620a16c00ee3b7eae85769a296f29824347ab577 The test are back to green.

On Tue, Nov 26, 2019 at 12:22 PM Valentin Clement (バレンタイン クレメン) < notifications@github.com> wrote:

@nicolasvasilache https://github.com/nicolasvasilache Yes just modifying the path to the libs fixes the two tests (remove the mlir-cpu-runner directory in the RUN line for the mlir-cpu-runner/utils.mlir and mlir-cpu-runner/linalg_integration_test.mlir tests.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tensorflow/mlir/issues/274?email_source=notifications&email_token=ACNNU5GHVZA44CYCDI6NYVLQVVLNRA5CNFSM4JRZJ6OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFGZRFA#issuecomment-558733460, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNNU5GHPZYGGEP73I3KQ2TQVVLNRANCNFSM4JRZJ6OA .

-- N

clementval commented 4 years ago

@nicolasvasilache Thanks for the quick fix!