Closed DavidTruby closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Arm has signed the CLA
Hey @DavidTruby,
Thanks for the contribution! It is exciting to see an OpenMP dialect getting started :) Was there a high-level description of the dialect sent to mlir@tensorflow.org already? I think it'd be great to make sure everyone is aligned first. I actually sent a PR (haven't merged yet) to describe a bit the process: https://github.com/tensorflow/mlir/pull/263/files
Hi @joker-eph, the summary went out to the list today, I just posted this early to get an idea if I was heading in the right direction with it!
Reopened on Phabricator
This establishes an OpenMP dialect with an initial simple operation, barrier.
omp.barrier
takes no arguments and returns nothing, but implies a side effect (synchronization of all OpenMP threads)NOTE: depends on #244