[Linalg] Change attribute n_loop_types to iterator

tetuante commented 4 years ago

This addresses issue #270. Linalg is updated to take the same form of iterator_types than vector contraction.

Change-Id: Iedae21efded776e65a43b2df2043cd981644b213

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

tetuante commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

nicolasvasilache commented 4 years ago

You will need to sign the CLA to merge this. Thanks!

tetuante commented 4 years ago

@googlebot I fixed it.

tetuante commented 4 years ago

@googlebot I fixed it.

tetuante commented 4 years ago

@googlebot I signed it!

nicolasvasilache commented 4 years ago

Trying to remove the CLA:no label and see if it retriggers a check somehow. Sorry this is so painful.. Quick question, are you using a corporate address and maybe this detects that there must be a company-wide CLA?

tetuante commented 4 years ago

The first time I guess a I signed the CLA with my personal gmail account but committed with my university one. Then, I signed another CLA with my university email , which is the one I use in github..... I don't think my university (UCM) is asks for company-wide CLA. I will try to figure it out

tetuante commented 4 years ago

@googlebot I fixed it.

tetuante commented 4 years ago

talking to the bot triggered the checking again...and was not succesful. Is there a way to know if it is about the university CLA?

nicolasvasilache commented 4 years ago

I'll ask internally, could you maybe try a new PR duplicate of this one see if it helps that you have signed the CLA before sending the PR? Also, is the email on which we communicated the proper one?

tetuante commented 4 years ago

@googlebot I fixed it.

tetuante commented 4 years ago

I will try a new PR then. Yes, my primary email in github is the same we have been using to communicate last week. I tried to add my other email as a valid email in my GitHub account, but I guess "googlebot" is checking the email of the commit

tetuante commented 4 years ago

I cannot create a new Pull Request from the same branch in my forked repo; GitHub detects it is actually this one and redirects me here. Shall I close this one and start again?

joker-eph commented 4 years ago

The problem is that the email used for the commit is @arm.com ; if you're contributing as part of your contract with ARM then you may need to synchronize with them for signing the CLA.

tetuante commented 4 years ago

@arm?? No, no. It was my mistake then! I was trying to commit with my @ucm account. Indeed, I don't have @arm address in GitHub! Ok, I will see what I did wrong. But then, I guess it is better to close this request and start a new one

tensorflow / mlir