search

tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.74k stars 259 forks source link

[spirv] Add CompositeInsertOp operation. #292

Closed denis0x0D closed 4 years ago

denis0x0D commented 4 years ago

A CompositeInsertOp operation make a copy of a composite object, while modifying one part of it.

@antiagainst @MaheshRavishankar can you please take a look, thanks!

denis0x0D commented 4 years ago

@antiagainst thanks a lot for review! Updated.

denis0x0D commented 4 years ago

Seems like tests failed because of this error: /tmpfs/src/git/llvm/llvm/projects/mlir/test/lib/IR/TestSymbolUses.cpp:18:25: fatal error: TestDialect.h: No such file or directory compilation terminated. projects/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/build.make:82: recipe for target 'projects/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o' failed

antiagainst commented 4 years ago

There is also a conflict. Could you rebase against master?