Closed thewilsonator closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thanks!
My pleasure.
Seem like @nicolasvasilache submitted a fix as well: https://github.com/tensorflow/mlir/commit/0f79da8aaebd8b9605ee28762299b49b21630147
My apologies if this was redundant, @joker-eph pinged me about this on Monday but I only popped it off the stack yesterday, didn't check OSS to see if someone else was working on this.
No problems. So this should be closed?
Please double check on your side, if it works for you please close.
On Sat, Dec 14, 2019 at 7:36 PM Nicholas Wilson notifications@github.com wrote:
No problems. So this should be closed?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tensorflow/mlir/pull/316?email_source=notifications&email_token=ACNNU5HIDDQFYTZWQUFB4TDQYV3ZJA5CNFSM4J2IEZY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4OOVY#issuecomment-565765975, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNNU5BIT2ZMNV4CV4TW45DQYV3ZJANCNFSM4J2IEZYQ .
-- N
This is liable to cause mangling issue on Windows where class and struct are mangled differently.