tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.73k stars 257 forks source link

Fix warning with struct forward declared as class #316

Closed thewilsonator closed 4 years ago

thewilsonator commented 4 years ago

This is liable to cause mangling issue on Windows where class and struct are mangled differently.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

thewilsonator commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ftynse commented 4 years ago

Thanks!

thewilsonator commented 4 years ago

My pleasure.

River707 commented 4 years ago

Seem like @nicolasvasilache submitted a fix as well: https://github.com/tensorflow/mlir/commit/0f79da8aaebd8b9605ee28762299b49b21630147

nicolasvasilache commented 4 years ago

My apologies if this was redundant, @joker-eph pinged me about this on Monday but I only popped it off the stack yesterday, didn't check OSS to see if someone else was working on this.

thewilsonator commented 4 years ago

No problems. So this should be closed?

nicolasvasilache commented 4 years ago

Please double check on your side, if it works for you please close.

On Sat, Dec 14, 2019 at 7:36 PM Nicholas Wilson notifications@github.com wrote:

No problems. So this should be closed?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tensorflow/mlir/pull/316?email_source=notifications&email_token=ACNNU5HIDDQFYTZWQUFB4TDQYV3ZJA5CNFSM4J2IEZY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4OOVY#issuecomment-565765975, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNNU5BIT2ZMNV4CV4TW45DQYV3ZJANCNFSM4J2IEZYQ .

-- N