search

tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.73k stars 257 forks source link

1.the type of op.getIndex() is unsigned, the value is always greater … #328

Closed leike666666 closed 4 years ago

leike666666 commented 4 years ago

…than or equal to 0

2.the function hasConstantoffsetSizesAndStrides is defined but not used

joker-eph commented 4 years ago

Thanks for the fixes! In general please split unrelated changes in multiple pull-requests.

It seems that getIndex() was changed to return a signed-type just yesterday though, can you just drop this change from this PR? (and update the description accordingly)