search

tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.73k stars 257 forks source link

fix isValidDim for block arg case #331

Closed bondhugula closed 4 years ago

bondhugula commented 4 years ago

Signed-off-by: Uday Bondhugula uday@polymagelabs.com

bondhugula commented 4 years ago

Could you please describe what is the problem that you are fixing in the commit message? Thanks!

I was thinking the test case was sufficient - but have updated the commit message. Thanks!

ftynse commented 4 years ago

Could you please describe what is the problem that you are fixing in the commit message? Thanks!

I was thinking the test case was sufficient - but have updated the commit message. Thanks!

I'm nitpicking, but as the scale of the project grows, I'm expecting some people following the development will read commit messages but will not take the time to look into the actual change. Thanks!

bondhugula commented 4 years ago

Could you please describe what is the problem that you are fixing in the commit message? Thanks!

I was thinking the test case was sufficient - but have updated the commit message. Thanks!

I'm nitpicking, but as the scale of the project grows, I'm expecting some people following the development will read commit messages but will not take the time to look into the actual change. Thanks!

Yes, you are right, I agree.