tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.73k stars 257 forks source link

Add missed syntax group name in Vim syntax #332

Closed chelxom closed 4 years ago

chelxom commented 4 years ago

Currently some syntax keyword commands don't contain proper syntax group names, and the commands are ill-formed. This causes Vim to fail to read the syntax configuration of MLIR.

This PR fixes this by adding mlirOps as the group name for those syntax commands.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

chelxom commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

joker-eph commented 4 years ago

Fixed in https://github.com/llvm/llvm-project/commit/d2a8e14177f0b2d48b38bd77004df0c99d675dd1