Add FIR, the Flang project's IR, to the dialect registry.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

schweitzpgi commented 5 years ago

Nvidia has signed the CLA.

@googlebot I signed it!

googlebot commented 5 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

joker-eph commented 5 years ago

(Overriding the CLA on account of a contribution from Nvidia)

schweitzpgi commented 5 years ago

I am unclear on what happened here. Why did the bot reject this simple change?

joker-eph commented 5 years ago

It didn’t reject: the PR was closed by the commit linked in the closing message (you commit was merged internally in Google and then mirrored to GitHub, our tooling added “Closes #62” to the commit message so that it links this PR to the commit, and GitHub automatically closes the PR)

schweitzpgi commented 5 years ago

Oh! OK, thanks for the explanation.

tensorflow / mlir