search

tensorflow / models

Models and examples built with TensorFlow
Other
77.03k stars 45.77k forks source link

DenseNets in Tensorflow #8278

Closed Eshan-Agarwal closed 4 years ago

Eshan-Agarwal commented 4 years ago

Is TensorFlow have DenseNetarchitecture like others ResNetetc. Can I add DenseNet architecture in Tensorflow/Models. I previously worked on it. Or just load it using kerasas TF supports keras.

saberkun commented 4 years ago

Hi Eshan-Agarwal, Because DenseNet is inside keras.application and users may just need add some regularization to train a keras.application model, it does not look like an important model to re-implement. Here is an example: https://github.com/tensorflow/models/blob/master/official/vision/image_classification/resnet_imagenet_main.py#L191 We do not have plan to add DenseNet at this moment.

Eshan-Agarwal commented 4 years ago

@saberkun Thanks and okay.

bhack commented 4 years ago

@Eshan-Agarwal If you are interested ina a Tensorflow2 impl https://github.com/okason97/DenseNet-Tensorflow2 /cc @okason97

Eshan-Agarwal commented 4 years ago

@bhack thank you so much it will help.

srilman commented 4 years ago

Not to be rude @saberkun, but the reasoning that "keras.applications has DenseNet so there's no need to reimplement it" seems like a pretty weak argument. ResNet and ResNet_v2 are both implemented in keras.applications but tensorflow/models also has an implementation which IMO is more flexible but not as easy to use.

To be fair, ResNets are much more popular than DenseNets. But at the same time, I do think a more flexible version of DenseNets (as well as less popular models) would be useful for people who have more varied use cases. For example, one could not just use the DenseNet provided in Keras directly to train for CIFAR, even though the original paper does (because the first couple of layers are different).

BTW, would be happy to contribute if its OK!

saberkun commented 4 years ago

Hi @srilman, the official models cost more to maintain. We are in progress to build general vision modeling libraries. I think it would be chance to have DenseNet empowered by the library as we also want to bridge the existing object detection and slim model zoo.

Defer to @jaeyounkim for the detailed plan. Right now, we establish the community folder. If there is a very good DenseNet TF repository, we could review and recommend it.

jaeyounkim commented 4 years ago

@srilman I've added a "community suggestion" label to this issue to keep tracking suggestions from the community.

We will welcome more contributions for new models once we release our new modeling library for computer vision. We will share our roadmap with the community soon.

Please check our contribution guidelines for paper code for the time being.

bhack commented 4 years ago

@jaewoosong Are you closing the issues tagged as "community suggestion" or just this one?

jaeyounkim commented 4 years ago

I am going to close all the issues labelled as "community suggestion" because I will be tracking "community suggestion" issues separately and review them monthly.

Feel free to reopen it if you have more suggestions.

bhack commented 4 years ago

If it is for an internal review plan it is ok but it could generate duplication cause I think that users will not check closed ticket so often.

jaeyounkim commented 4 years ago

@bhack I've created a new issue to list all requests for paper implementation. Please create a new issue if you want to request for other paper implementations after checking our model selection criteria.