search

tensorflow / neural-structured-learning

Training neural models with structured signals.
https://www.tensorflow.org/neural_structured_learning
Apache License 2.0
980 stars 189 forks source link

Added CNN adversarial learning tutorial notebook [Updated with Feedback] #76

Closed dipanjanS closed 3 years ago

dipanjanS commented 3 years ago

Hi @arjung as discussed. Please find the adversarial learning notebook example updated based on feedback from your side.

You can review it and add in any comments as needed to fix any pending issues. Also would be great if you can close PR: https://github.com/tensorflow/neural-structured-learning/pull/67

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

arjung commented 3 years ago

Hi @dipanjanS, happy new year! Just wanted to check in and see if you had a chance to look at my latest comments. They are all easy to address, so I think we're very close to being able to merge this in.

dipanjanS commented 3 years ago

@arjung wishing you a happy new year! Yes, apologies on the delay got a bit busy. Let me take care of this by this week and I'll push in the changes.

arjung commented 3 years ago

Awesome, thanks!

arjung commented 3 years ago

Hi @dipanjanS, were you able to look into this PR? It would be great to have this resolved soon as it's been open for a long time. Thanks!

dipanjanS commented 3 years ago

Hi @arjung sorry I thought this got reflected here but for some reason the push didn't reflect here, I did a force push now and you should be able to see the changes, feel free to review and let me know and we can close on this soon definitely like you mentioned

arjung commented 3 years ago

Thanks Dipanjan! The latest version looks great!

dipanjanS commented 3 years ago

Thanks @arjung feel free to merge it as necessary and in case of any other edits you can let me know anytime before that! Apologies on the delay I completely missed on the fact that the push didn't go through the first time.

On Mon, Feb 22, 2021 at 8:17 PM arjung notifications@github.com wrote:

Thanks Dipanjan! The latest version looks great!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://mailtrack.io/trace/link/e5108281ace18f2fa9dab004938a655e39c7397e?url=https%3A%2F%2Fgithub.com%2Ftensorflow%2Fneural-structured-learning%2Fpull%2F76%23issuecomment-783426253&userId=3535544&signature=7a11da373922a71d, or unsubscribe https://mailtrack.io/trace/link/d23d8aa1e3796efd4393a3ba2e655a251ee766d5?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA2J3RYRZKPMSJRRPBXJ5VLTAJVBHANCNFSM4TPJUJ5A&userId=3535544&signature=bece0aac6550508c .