search

tensorflow / ngraph-bridge

TensorFlow-nGraph bridge
Other
137 stars 65 forks source link

"switch (dt)" does not include case "PLAIDML_DATA_BFLOAT16" in plaidml_translate.cpp #447

Open dbonner opened 4 years ago

dbonner commented 4 years ago

ngraph-bridge fails to build with the plaidml backend, giving an error when compiling: ngraph-bridge/build_cmake/ngraph/src/ngraph/runtime/plaidml/plaidml_translate.cpp

ngraph-bridge/build_cmake/ngraph/src/ngraph/runtime/plaidml/plaidml_translate.cpp:105:13: warning: 
      enumeration value 'PLAIDML_DATA_BFLOAT16' not handled in switch [-Wswitch]
    switch (dt)
            ^
ngraph-bridge/build_cmake/ngraph/src/ngraph/runtime/plaidml/plaidml_translate.cpp:105:13: note: 
      add missing switch cases
    switch (dt)
            ^
ngraph-bridge/build_cmake/ngraph/src/ngraph/runtime/plaidml/plaidml_translate.cpp:124:1: error: 
      control may reach end of non-void function [-Werror,-Wreturn-type]

I edited ngraph/runtime/plaidml/plaidml_translate.cpp and added under switch (dt): case PLAIDML_DATA_BFLOAT16: return "as_bfloat16(" + tensor_name + ", 16)";

It then built successfully.

dbonner commented 4 years ago

I have made a pull request at the ngraph repo: compare code