get_model_creator function is creating standard attention model even when hparams.attention is not set

tensorflow / nmt

TensorFlow Neural Machine Translation Tutorial

Apache License 2.0

6.35k stars 1.96k forks source link

get_model_creator function is creating standard attention model even when hparams.attention is not set #400

Open ranjita-naik opened 5 years ago

ranjita-naik commented 5 years ago

hparams.attention check seems to be missing in get_model_creator function while creating attention model; It only checks if hparams.attention_architecture == "standard". As a result, AttentionModel is created even when hparams.attention is not set.