Open we-taper opened 3 years ago
After talking this over with the Cirq people it turns out that this is intended behavior. So we have to turn around and update our serializer functionality to support Toffoli and CCZ.
I am having the same issue, but the workaround @we-taper mentioned does not work for me, since I am getting the same error for the ControlledGate. @we-taper: Are you using the regular TFQ version or the nightly one?
@Danielle-Schuman I was using the nightly one at the time.
Ok, thank you for the answer, @we-taper :). I was using the regular version, so that might have caused the different behaviour. I meanwhile have found a workaround, though. (I just implemented the Toffoli-gate in a decomposed manner, as described in https://en.wikipedia.org/wiki/Toffoli_gate#/media/File:Qcircuit_ToffolifromCNOT.svg , that worked with the regular TFQ version, too.)
Thanks! @Danielle-Schuman
Actually, why not working with the nightly-version? The major benefit is that gates will be implemented natively which means faster execution. So far it has been quite smooth for me to use the nightly version (or to be specific tfq-nightly==0.5.0.dev20210218
).
I see there is a pull request under review to fixing this thread, is there plans to merge that soon? It's not breaking since you can use the techniques presented above to solve the problem, but it's a weird interaction.
When a multi-qubit X gate is created by the
.controlled
method, it maybe automatically promoted tocirq.TOFFOLI
gate which isn't supported by TFQ.Minimal example:
Currently, the work-around is to use
cirq.ControlledGate(sub_gate=cirq.X, num_controls=3).on(*qbs)
instead. Similar problem happen tocirq.Z
as well, which is promoted tocirq.CCZ
. Luckily,cirq.Y
works becausecirq.CCY
does not exist.