tensorflow / quantum

Hybrid Quantum-Classical Machine Learning in TensorFlow
https://www.tensorflow.org/quantum
Apache License 2.0
1.77k stars 558 forks source link

Add cuQuantum-based TFQ native ops and layers #774

Closed QuantumJaeYoo closed 1 year ago

QuantumJaeYoo commented 1 year ago

This has large changes and requires some deps error, rewrite documentations, and fixed internal bugs inside random ops, and so forth.

Please look at the PR descriptions in my repo to understand the procedures : https://github.com/jaeyoo/quantum/pulls?q=is%3Apr+is%3Aclosed

Breaking Changes

Major Features and Improvements

Source: https://github.com/Sinestro38/quantum/blob/master/tensorflow_quantum/release.md cc: @MichaelBroughton @QuantumJaeYoo

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

QuantumJaeYoo commented 1 year ago

@MichaelBroughton Hi Michael, @Sinestro38 and I could reduce the number of files in this PR for you to review this PR easily. PTAL.

zaqqwerty commented 1 year ago

Just a note, could it make sense to squash-merge instead of merge? Noticed commit history getting cluttered on main

QuantumJaeYoo commented 1 year ago

@zaqqwerty Thank you for the idea. I squashed all commits. Could you please also review this PR? @MichaelBroughton Please feel free to add kokoro:run tag and then let's debug it together.

QuantumJaeYoo commented 1 year ago

@zaqqwerty @MichaelBroughton After fixing the merge conflict, the squashed commits reverted... I hope we could use "Squash and merge" button before merging this PR.

스크린샷 2023-06-08 오후 7 33 20
QuantumJaeYoo commented 1 year ago

I will split this PR into multiple easier and shorter PRs.