search

tensorflow / similarity

TensorFlow Similarity is a python package focused on making similarity learning quick and easy.
Apache License 2.0
1.01k stars 104 forks source link

Black isort #277

Closed yonigottesman closed 2 years ago

yonigottesman commented 2 years ago

Hi @owenvallis I split this pr to 3 commits so it will be easier to review. 1) the changes needed to check for black and add pre-commit hooks for black and isort 2) formatting all the code 3) add ignore-revs file so that git blame will ignore commit from stage 2

yonigottesman commented 2 years ago

@owenvallis i get it if someone else wants to do all the formatting. It can be done independently from this pr, just run black and isort with these parameters (commit 2) and only then i'll add commits 1,3

owenvallis commented 2 years ago

Thanks for the PR @yonigottesman, LGTM. I hadn't seen the ignore-revs file before, but look like a nice way to remove formatting changes like this from the blame history.

One other question I had was regarding the pyproject.toml file. This is also new to me, but I took a look at the PEP doc and it seems like a good idea. Would we want to move over all the other install deps to the toml file at some point in a future commit? wdyt?