Google Summer of Code - Githubissues

tensorflow / similarity

TensorFlow Similarity is a python package focused on making similarity learning quick and easy.

Apache License 2.0

1.01k stars 104 forks source link

Google Summer of Code #286

Closed abhisharsinha closed 2 years ago

abhisharsinha commented 2 years ago

This work was part of my Google Summer of Code project. The following are the major contributions of the project.

Addition of multiple negatives ranking loss
Addition of an example notebook for fine-tuning CLIP using multiple negatives ranking loss

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

owenvallis commented 2 years ago

Thanks for the PR! I'll review the notebook soon and I left a few comments on the loss.

owenvallis commented 2 years ago

@abhisharsinha, let me know your thoughts on the PR comments and we can get this merged into the dev branch.

owenvallis commented 2 years ago

Thanks for updating the loss. I meant to revert the changes to pyproject.toml but accidentally deleted the file. The change in the line-length was causing the Black formatting checks to fail.

Can you please add pyproject.toml back with the following, thanks.

[tool.isort]
profile = "black"

[tool.black]
 line-length = 119

owenvallis commented 2 years ago

Looks like the Black and Isort formatting checks are failing for tensorflow_similarity/losses/multinegrank_loss.py. Otherwise looks good to go, thanks.