search

tensorflow / similarity

TensorFlow Similarity is a python package focused on making similarity learning quick and easy.
Apache License 2.0
1.01k stars 104 forks source link

Indexing #314

Closed dnazila closed 1 year ago

dnazila commented 1 year ago

Adding linear search, faiss approximate NN lookup, cached store, and redis store

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ebursztein commented 1 year ago

Looks promising but there are quite a few types, documentation and else branch with error values missing. Also I didn't see a notebook that helps understand how to use the various storage -- seems important. last but not least the Readme needs to be updated to discuss backend storage.