tensorflow / skflow

Simplified interface for TensorFlow (mimicking Scikit Learn) for Deep Learning
Apache License 2.0
3.18k stars 439 forks source link

Fixed learning_rate in trainer #109

Closed liyongsea closed 8 years ago

liyongsea commented 8 years ago

Variable _learning_rate is wrongly named in trainer.py. I fixed that and I added a test to check this part of the code.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


liyongsea commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

codecov-io commented 8 years ago

Current coverage is 89.58%

Merging #109 into master will increase coverage by +0.20% as of ad8e499

@@            master    #109   diff @@
======================================
  Files           26      26       
  Stmts          989     989       
  Branches       160     160       
  Methods          0       0       
======================================
+ Hit            884     886     +2
+ Partial         50      49     -1
+ Missed          55      54     -1

Review entire Coverage Diff as of ad8e499

Powered by Codecov. Updated on successful CI builds.

terrytangyuan commented 8 years ago

Thanks!

ilblackdragon commented 8 years ago

Thanks for fix and especially for the test! :+1: