Closed liyongsea closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
89.58%
Merging #109 into master will increase coverage by +0.20% as of
ad8e499
@@ master #109 diff @@
======================================
Files 26 26
Stmts 989 989
Branches 160 160
Methods 0 0
======================================
+ Hit 884 886 +2
+ Partial 50 49 -1
+ Missed 55 54 -1
Review entire Coverage Diff as of
ad8e499
Powered by Codecov. Updated on successful CI builds.
Thanks!
Thanks for fix and especially for the test! :+1:
Variable _learning_rate is wrongly named in trainer.py. I fixed that and I added a test to check this part of the code.