search

tensorflow / skflow

Simplified interface for TensorFlow (mimicking Scikit Learn) for Deep Learning
Apache License 2.0
3.18k stars 439 forks source link

Make estimator.predict memory efficient for large n_classes #115

Closed elqursh closed 8 years ago

elqursh commented 8 years ago

For multi-class classification estimator.predict currently appends all the predictions and then argmax the resulting tensor. For a large number of classes this tensor is huge and may not fit in memory.

This CL changes the behavior to argmax before appending the results for the batch.

codecov-io commented 8 years ago

Current coverage is 90.50%

Merging #115 into master will not affect coverage as of aae5841

@@            master   #115   diff @@
=====================================
  Files           27     27       
  Stmts         1043   1043       
  Branches       159    159       
  Methods          0      0       
=====================================
  Hit            944    944       
  Partial         47     47       
  Missed          52     52

Review entire Coverage Diff as of aae5841

Powered by Codecov. Updated on successful CI builds.

ilblackdragon commented 8 years ago

Awesome, thanks!