search

tensorflow / skflow

Simplified interface for TensorFlow (mimicking Scikit Learn) for Deep Learning
Apache License 2.0
3.18k stars 439 forks source link

Fix examples given new tensorflow rnn interface. Update bidirectional… #119

Closed dgboy2000 closed 8 years ago

dgboy2000 commented 8 years ago

… rnn to return final state.

codecov-io commented 8 years ago

Current coverage is 90.70%

Merging #119 into master will not affect coverage as of 6f5fc68

@@            master   #119   diff @@
=====================================
  Files           27     27       
  Stmts         1044   1044       
  Branches       159    159       
  Methods          0      0       
=====================================
  Hit            947    947       
  Partial         46     46       
  Missed          51     51

Review entire Coverage Diff as of 6f5fc68

Powered by Codecov. Updated on successful CI builds.

terrytangyuan commented 8 years ago

@dgboy2000 Thanks! @ilblackdragon Do we need to keep old version of TF as a separate environment? (I haven't got chance to track the changes yet)

ilblackdragon commented 8 years ago

No, we should be rolling with changes - let's update the README as well that it's now >= 0.7. The API is going to keep changing and if people want to use tensorflow - they should be updating it.

One thing we should add is maybe a version check, e.g. if let people know if the version of tensorflow is below supported - added #120 for this.