tensorflow / skflow

Simplified interface for TensorFlow (mimicking Scikit Learn) for Deep Learning
Apache License 2.0
3.18k stars 439 forks source link

Use the public TensorFlow API to access SaverDef #127

Closed mrry closed 8 years ago

mrry commented 8 years ago

The current code accesses SaverDef using an obsolete private API. This change makes skflow compatible with TensorFlow 0.7.0 and up.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


codecov-io commented 8 years ago

Current coverage is 90.38%

Merging #127 into master will not affect coverage as of 5075766

@@            master    #127   diff @@
======================================
  Files           27      27       
  Stmts         1061    1061       
  Branches       164     164       
  Methods          0       0       
======================================
  Hit            959     959       
  Partial         50      50       
  Missed          52      52       

Review entire Coverage Diff as of 5075766

Powered by Codecov. Updated on successful CI builds.

mrry commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

terrytangyuan commented 8 years ago

Thanks!