added stacked autoencoder

tensorflow / skflow

Simplified interface for TensorFlow (mimicking Scikit Learn) for Deep Learning

Apache License 2.0

3.18k stars 439 forks source link

added stacked autoencoder #152

Closed rajarsheem closed 8 years ago

rajarsheem commented 8 years ago

implemented a simple deep autoencoder. will be very helpful if you suggest something needs to change or presence of any bug.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

rajarsheem commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

ilblackdragon commented 8 years ago

You can also see errors here: https://travis-ci.org/tensorflow/skflow/builds/118334195

ilblackdragon commented 8 years ago

Additionally, skflow development moved to http://github.com/tensorflow/tensorflow/ (under tensorflow/contrib/skflow) so can you please move PR there?

Thanks!

ilblackdragon commented 8 years ago

@rajarsheem do you mind moving this into skflow/ examples in tensorflow repo? then we can refactor it into a estiamtor.

rajarsheem commented 8 years ago

@ilblackdragon i have some commits to push. let me update the PR first. what's say ?

rajarsheem commented 8 years ago

@ilblackdragon can you point me to the new skflow dir under tensorflow ? my guess : https://github.com/tensorflow/tensorflow/tree/master/tensorflow/contrib/learn/python/learn

ilblackdragon commented 8 years ago

Feel free to update this PR - we can discuss more here. Yes, skflow moved into contrib/learn - https://github.com/tensorflow/tensorflow/tree/master/tensorflow/contrib/learn/python/learn

Examples are at https://github.com/tensorflow/tensorflow/tree/master/tensorflow/examples/skflow/

rajarsheem commented 8 years ago

@ilblackdragon looks like couple of docstrs need to be added for a successful travis build. is everything else looks okay ?

ilblackdragon commented 8 years ago

@rajarsheem It looks cleaner. Few missing pieces - you need at least one-two tests and you should inherit from _skflow.BaseEstimator (see https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/learn/python/learn/estimators/base.py#L66 for examples of that).

Also, I'm going to actually delete all the code from tensorflow/skflow repo - now that skflow is released with tensorflow v0.8 (this skflow will for now just re-import it from tensorflow). So do you mind moving your PR into tensorflow/tensorflow repo?

terrytangyuan commented 8 years ago

@rajarsheem We have added DNNAutoencoder here. Feel free to submit any issues or enhancements there instead, e.g. LSTMAutoencoder, etc. Thanks!