tensorflow / skflow

Simplified interface for TensorFlow (mimicking Scikit Learn) for Deep Learning
Apache License 2.0
3.18k stars 439 forks source link

Update text.py #44

Closed spenthil closed 8 years ago

spenthil commented 8 years ago

Typo in tokenizer regex

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


codecov-io commented 8 years ago

Current coverage is 94.73%

Merging #44 into master will not affect coverage as of af7e2a3

@@            master     #44   diff @@
======================================
  Files           22      22       
  Stmts          778     778       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            737     737       
  Partial          0       0       
  Missed          41      41       

Review entire Coverage Diff as of af7e2a3

Powered by Codecov. Updated on successful CI builds.

ilblackdragon commented 8 years ago

Why is this a typo?

According to unicode string documentation ur'abcd' is valid way to express raw unicode strings.

spenthil commented 8 years ago

So it is - never thought to combine raw strings and unicode in Python 2, duh.

So this is a Python 3 compatibility issue. Is that something this project wants to support?