search

tensorflow / skflow

Simplified interface for TensorFlow (mimicking Scikit Learn) for Deep Learning
Apache License 2.0
3.18k stars 439 forks source link

Fixes with DataFeeder, issue #50 at github. #75

Closed makseq closed 8 years ago

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

makseq commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

terrytangyuan commented 8 years ago

Thanks! Perhaps could you add a unit test for this? cc: @ilblackdragon

makseq commented 8 years ago

Yes, I'll do it. We've started to discuss it with @ilblackdragon, there are some troubles with old unit tests.

terrytangyuan commented 8 years ago

Got it. Thanks.

terrytangyuan commented 8 years ago

@makseq You can test it locally first - Travis is pretty slow. e.g. nosetests and pylint skflow

makseq commented 8 years ago

Ok!

codecov-io commented 8 years ago

Current coverage is 91.84%

Merging #75 into master will increase coverage by +4.45% as of f279832

@@            master     #75   diff @@
======================================
  Files           22      23     +1
  Stmts          730     797    +67
  Branches       110     120    +10
  Methods          0       0       
======================================
+ Hit            638     732    +94
  Partial         34      34       
+ Missed          58      31    -27

Review entire Coverage Diff as of f279832

Powered by Codecov. Updated on successful CI builds.