search

tensorflow / swift-models

Models and examples built with Swift for TensorFlow
Apache License 2.0
646 stars 146 forks source link

What is TF-427? #714

Closed xanderdunn closed 3 years ago

xanderdunn commented 3 years ago

I was verifying the gradients on one of my models and wanted to increase the precision from Float to Double to see how it affected the error on the calculation (recommended here). My model is using TransformerEncoder and I saw that it has Scalar type hard-coded to Float, with a note that it can be made into a generic constraint when TF-427 is resolved.

I thought perhaps it was referring to https://github.com/tensorflow/swift/issues#427 or https://github.com/tensorflow/swift-models/issues#427, but they appear to be unrelated. Is this an internal issue tracker? I'm wondering what the TF-427 issue is that prevents it from being made into a generic constraint on Scalar.

xanderdunn commented 3 years ago

Oh wow the GitHub issue automatically formats TF-427 to the Swift bug tracker issue. I've seen SR-# but didn't realize some of them were TR-#.