tensorflow / swift

Swift for TensorFlow
https://tensorflow.org/swift
Apache License 2.0
6.12k stars 608 forks source link

corrected Windows installation verification step instructions #430

Closed maxvol closed 4 years ago

maxvol commented 4 years ago

corrected Windows installation verification step instructions as discussed here - https://github.com/tensorflow/swift/issues/421

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

ematejska commented 4 years ago

@maxvol Could you please sign the CLA?

maxvol commented 4 years ago

@maxvol Could you please sign the CLA?

@ematejska done! sorry for delay

maxvol commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ematejska commented 4 years ago

The page now needs to take into consideration all platforms.

dabrahams commented 4 years ago

@compnerd PTAL. Should we change the prompt character from $ to >?

compnerd commented 4 years ago

I think that fixing the prompt character can be done in a follow up as it was incorrect before this.

compnerd commented 4 years ago

Thanks @maxvol for the improvements!