search

tensorflow / swift

Swift for TensorFlow
https://tensorflow.org/swift
Apache License 2.0
6.12k stars 608 forks source link

Updating for `@derivative(of:)` usage in Raw TensorFlow Operators tutorial #445

Closed BradLarson closed 4 years ago

BradLarson commented 4 years ago

The current Raw TensorFlow Operators tutorial uses the deprecated @differentiable(vjp:) syntax, which will be removed in the 0.9 release toolchain (and is already removed in the nightlies). This replaces that implementation and description with the modern equivalents.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

ematejska commented 4 years ago

I think we need this in the 0.9 release branch first and this outstanding. Please don't merge until 0.9 Colab goes live.

ematejska commented 4 years ago

Actually, does this already work in 0.8? We might be good here.

dan-zheng commented 4 years ago

This patch should be valid in 0.8 and 0.9.

BradLarson commented 4 years ago

Yes, I can confirm this works in 0.8 as well, wasn't sure if the best approach was to start here and cherry-pick back to tensorflow-0.9.