search

tensorflow / tensorboard-plugin-example

Apache License 2.0
135 stars 59 forks source link

Make reload for greeter-card take no arguments #12

Closed chihuahua closed 7 years ago

chihuahua commented 7 years ago

The greeter card's reload method used to take run and tag arguments, which caused a bug (#11) because the greeter dashboard would call the card's reload method with no arguments.

We now introduce a new _fetchNewData(run, tag) method to the greeter-card component which is used as an observer and used indirectly by the card's reload method.

Fixes #11.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot commented 7 years ago

CLAs look good, thanks!