search

tensorflow / tensorboard

TensorFlow's Visualization Toolkit
Apache License 2.0
6.68k stars 1.65k forks source link

'probabilities' predict_output_tensor is confusing #2938

Open htappen opened 4 years ago

htappen commented 4 years ago

I noticed in https://github.com/tensorflow/tensorboard/blob/master/tensorboard/plugins/interactive_inference/witwidget/notebook/base.py#L510 that it expects a few hard-coded tensor names for output. A few issues here:

1) Could WIT just default to grabbing the first tensor in case predict_output_tensor isn't set? That will match many Keras models. 2) In the case there are multiples, could we have a smarter guess? Keras Sequential will use "output_1", or "dense_1" in many cases. Not sure what estimators will do. 3) Finally, if it's set incorrectly, could we have a better error message? Right now it's a black box called "probabilities"

We may want to make this a required param, too.

psybuzz commented 4 years ago

+jameswex, would you be the best person to assign this WIT related issue to?

jameswex commented 4 years ago

Thanks @psybuzz and @htappen . I'll take this and work with Henry offline to figure out the best solution