tensorflow / tensorboard

TensorFlow's Visualization Toolkit
Apache License 2.0
6.71k stars 1.66k forks source link

Plugin error message is unclear about the cause even with --verbose_failures #3798

Open jz-fb opened 4 years ago

jz-fb commented 4 years ago

Below is the output for building the plugin I'm working on and the error message doesn't provide me much to go on. Comparing the BUILD file of my plugin with Image plugin, they're almost identical outside of the plugin name and local files

$ bazel build tensorboard:tensorboard --verbose_failures ... ERROR: /home/z/projects/TB/z-2020-Tensorboard/tensorboard/plugins/z_video/z_video_dashboard/BUILD:7:15: Checking webfiles //tensorboard/plugins/z_video/z_video_dashboard:z_video_dashboard failed (Exit 1): ClosureWorker failed: error executing command (cd /home/z/.cache/bazel/_bazel_z/235ea30dc62cb54a15febc8e6e607029/execroot/org_tensorflow_tensorboard && \ exec env - \ bazel-out/host/bin/external/io_bazel_rules_closure/java/io/bazel/rules/closure/ClosureWorker @@bazel-out/k8-fastbuild/bin/tensorboard/plugins/z_video/z_video_dashboard/z_video_dashboard-webfiles-checker-args.txt) Execution platform: @local_config_platform//:host

There are other errors but I'm guessing they're just a consequence of the prior:

ERROR: tensorboard/plugins/z_video/z_video_dashboard/z-video-dashboard.html: Referenced ../tf-dashboard-common/tf-regex-group.html (/tf-dashboard-common/tf-regex-group.html) without depending on a web_library() rule providing it ERROR: tensorboard/plugins/z_video/z_video_dashboard/z-video-dashboard.html: Referenced ../tf-paginated-view/tf-paginated-view.html (/tf-paginated-view/tf-paginated-view.html) without depending on a web_library() rule providing it NOTE: Use suppress=["strictDependencies"] to make the errors above warnings Target //tensorboard:tensorboard failed to build ERROR: /home/z/projects/TB/z-2020-Tensorboard/tensorboard/BUILD:289:21 Checking webfiles //tensorboard/plugins/z_video/z_video_dashboard:z_video_dashboard failed (Exit 1): ClosureWorker failed: error executing command (cd /home/z/.cache/bazel/_bazel_z/235ea30dc62cb54a15febc8e6e607029/execroot/org_tensorflow_tensorboard && \ exec env - \ bazel-out/host/bin/external/io_bazel_rules_closure/java/io/bazel/rules/closure/ClosureWorker @@bazel-out/k8-fastbuild/bin/tensorboard/plugins/z_video/z_video_dashboard/z_video_dashboard-webfiles-checker-args.txt) Execution platform: @local_config_platform//:host INFO: Elapsed time: 0.454s, Critical Path: 0.16s INFO: 0 processes. FAILED: Build did NOT complete successfully

nfelt commented 4 years ago

Both of these look likely to be actual errors:

ERROR: tensorboard/plugins/z_video/z_video_dashboard/z-video-dashboard.html: Referenced ../tf-dashboard-common/tf-regex-group.html (/tf-dashboard-common/tf-regex-group.html) without depending on a web_library() rule providing it 

ERROR: tensorboard/plugins/z_video/z_video_dashboard/z-video-dashboard.html: Referenced ../tf-paginated-view/tf-paginated-view.html (/tf-paginated-view/tf-paginated-view.html) without depending on a web_library() rule providing it

I'd recommend checking your BUILD dependencies to be sure you are depending on the appropriate tf_web_library rules, e.g. for the latter "//tensorboard/components/tf_paginated_view".

jz-fb commented 4 years ago

Looks to be there... deps = [ "//tensorboard/components/tf_backend", "//tensorboard/components/tf_card_heading", "//tensorboard/components/tf_categorization_utils", "//tensorboard/components/tf_color_scale", "//tensorboard/components/tf_dashboard_common", "//tensorboard/components/tf_imports:d3", "//tensorboard/components/tf_imports:lodash", "//tensorboard/components/tf_imports:polymer", "//tensorboard/components/tf_paginated_view", "//tensorboard/components/tf_runs_selector", "//tensorboard/components/tf_tensorboard:registry", "@org_polymer_iron_icon", "@org_polymer_paper_button", "@org_polymer_paper_dialog", "@org_polymer_paper_icon_button", "@org_polymer_paper_input", "@org_polymer_paper_slider", "@org_polymer_paper_spinner", ], )

Here's the full file: load("//tensorboard/defs:web.bzl", "tf_web_library") `package(default_visibility = ["//tensorboard:internal"])` licenses(["notice"]) # Apache 2.0 ` tf_web_library( name = "z_video_dashboard", srcs = [ "z-video-dashboard.html", "z-video-loader.html", ], path = "/z-video-dashboard", visibility = ["//visibility:public"], deps = [ "//tensorboard/components/tf_backend", "//tensorboard/components/tf_card_heading", "//tensorboard/components/tf_categorization_utils", "//tensorboard/components/tf_color_scale", "//tensorboard/components/tf_dashboard_common", "//tensorboard/components/tf_imports:d3", "//tensorboard/components/tf_imports:lodash", "//tensorboard/components/tf_imports:polymer", "//tensorboard/components/tf_paginated_view", "//tensorboard/components/tf_runs_selector", "//tensorboard/components/tf_tensorboard:registry", "@org_polymer_iron_icon", "@org_polymer_paper_button", "@org_polymer_paper_dialog", "@org_polymer_paper_icon_button", "@org_polymer_paper_input", "@org_polymer_paper_slider", "@org_polymer_paper_spinner", ], )`

nfelt commented 4 years ago

I'm not sure then - if you can boil it down to a self-contained repro case I can take another look but otherwise it's hard to say what is missing in your local changes.

jz-fb commented 4 years ago

Does white space effect BUILD files?

jz-fb commented 4 years ago

Looks like the error originated from the HTML file, looks like that file name changed:

However I now get: W0707 17:33:43.833000 140237409199872 application.py:524] path /data/plugin/z_video/tags not found, sending 404

Any clue where it's going wrong/ what I should look for?

nfelt commented 4 years ago

This error probably suggests that either your plugin isn't registered properly, or that it's registered but not under the name z_video. Beyond that there's not much assistance we can provide without more details about the code.