tensorflow / tensorboard

TensorFlow's Visualization Toolkit
Apache License 2.0
6.67k stars 1.65k forks source link

RustBoard tasks #4422

Closed wchargin closed 3 years ago

wchargin commented 3 years ago

Feature tasks

If you’re interested, let me know, and I’ll assess whether it’s a good idea and provide guidance if appropriate.

Small-ish

Involved

These are mostly for feature parity. There are further ideas for new features—indexing, deferred blob loading, etc.—but let’s hold off on those.

Infra tasks

(I plan to take care of these.)

Other tasks that I plan to investigate:

bileschi commented 3 years ago

May I reserve plugin listing?

wchargin commented 3 years ago

Sure! You’ll want to update the list_plugins RPC handler to iterate over the map of data and extract the plugin names from the summary metadata, rather than just returning a hard-coded "scalars".

You can unit test this easily (follow existing examples), and for an end-to-end test you can compare a logdir with scalars to an empty logdir (since we don’t yet have tensor/blob sequence support).

wchargin commented 3 years ago

I’ve grabbed blob sequence support. It’s more involved than tensors but teaches approx. the same lessons, so I figure that I can grab it.

wchargin commented 3 years ago

I ended up also grabbing “make CRCs optional” because I was curious and it turns out to make things 15–60% faster (#4573), so I didn’t want to just leave that on the table that it might potentially get dropped.

wchargin commented 3 years ago

Thanks to @bileschi, @psybuzz, and @nfelt for your contributions! We’ve gotten all the important stuff by this point, so I’m closing this.