tensorflow / tensorboard

TensorFlow's Visualization Toolkit
Apache License 2.0
6.66k stars 1.65k forks source link

Vulcanize use of jsoup breaks Polymer templates inside tables #502

Open gar1t opened 7 years ago

gar1t commented 7 years ago

This is a pretty edge case issue, but from what I'm seeing it is impacting TensorBoard.

The root issue is described here:

You can see the bug manifest in the vulcanized output in index.html (snippet):

 <template is="dom-repeat" items="[[_getDevices(devicesForStats)]]">
          </template><table>
        <tr>
            <td>
              <input type="checkbox" value$="[[item.device]]" checked$="[[item.used]]" on-click="_deviceCheckboxClicked">
...

Note the all important template tag has been moved outside the table, breaking the component. The original snippet is here.

As this is impacting my work on plugins, I will look into a fix that I can make available.

wchargin commented 7 years ago

Yeah, we've hit this in the past, and summarized it as "Polymer's dom-* do not work with tables." Interesting to know that it's vulcanization and not Polymer proper. This explains why it's not reproducible in a polybin, because no vulcanization is performed.

We always just work around this. See, e.g., #191 and #319. An actual fix would be greatly appreciated.

cc @chihuahua