search

tensorflow / tensorboard

TensorFlow's Visualization Toolkit
Apache License 2.0
6.71k stars 1.66k forks source link

TensorBoard Embeddings fail if a "+" character is in LOG_DIR subdirectory filename #73

Open jart opened 7 years ago

jart commented 7 years ago

@austinstover said seventeen days ago in https://github.com/tensorflow/tensorflow/issues/10301:

System information

  • Occurs in Tutorial: DandelionMane's TF Dev Summit 2017 TensorBoard Tutorial
    • If learning_rate >= 1 (not that you would want to do that)
  • OS Platform: Windows 10
  • TensorFlow install: Binary
  • TensorFlow version: 1.1.0
  • Exact command to reproduce: Use a plus sign in the filename of one of LOG_DIR's subdirectories

Problem

The tensorboard embeddings tab throws an "Error fetching projector config" if a + sign is used in a log_dir subdirectory; that is, if the projector_config.pbtxt is in that subdirectory.

nfelt commented 6 years ago

FWIW we got another report of this internally, where the projector didn't even really handle the error correctly because apparently it returned a response of Unknown run: "<name of the run>" when a JSON response was expected, resulting in Uncaught SyntaxError: Unexpected token U in JSON at position 0 when trying to parse as JSON.

So in addition to fixing whatever is causing the + sign to be not found as a run, we should also fix the error so that we return JSON.

UsharaniPagadala commented 2 years ago

@jart

Closing this issue based on @nfelt 's comment.Please feel free to reopen if this still persists.Thanks

nfelt commented 2 years ago

@UsharaniPagadala my comment doesn't say anything that would justify closing this issue, it just confirms that this also happened internally. Let's not close this issue unless someone actually wasn't able to reproduce it against current TensorBoard.