tensorflow / tensorflow

An Open Source Machine Learning Framework for Everyone
https://tensorflow.org
Apache License 2.0
186.12k stars 74.27k forks source link

Implementation of CW-RNN? #1280

Closed aidangomez closed 7 years ago

aidangomez commented 8 years ago

Has anyone considered implementing the CW-RNN architecture discussed here: http://arxiv.org/abs/1402.3511

The cited results seem extremely promising, and the structure is quite simple. If it's not in the pipeline or already present, I may try implementing it myself.

theaverageguy commented 8 years ago

@aidangomez I would like to help you out! :)

aidangomez commented 8 years ago

@yash14123 Awesome! We'll see what Google has to say about any already present implementations.

girving commented 8 years ago

We'd love to have it in the models repo if anyone writes it: https://github.com/tensorflow/models!

elvinpoon commented 8 years ago

I'm working on it

aidangomez commented 8 years ago

Just opened a pull request

girving commented 8 years ago

@aidangomez Can you link to the pull request?

aidangomez commented 8 years ago

Here: https://github.com/tensorflow/models/pull/198

elvinpoon commented 8 years ago

I see. Let me know if u need any help.


发件人: Aidan Gomez notifications@github.com 发送时间: 2016年6月13日 23:45 收件人: tensorflow/tensorflow 抄送: elvinpoon; Manual 主题: Re: [tensorflow/tensorflow] Implementation of CW-RNN? (#1280)

Here: tensorflow/models#198https://github.com/tensorflow/models/pull/198

― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/tensorflow/tensorflow/issues/1280#issuecomment-225740698, or mute the threadhttps://github.com/notifications/unsubscribe/ASuxNtpeByyBt7-1Ba7aV2XMa2u33XO6ks5qLeuMgaJpZM4HiMj-.

aidangomez commented 7 years ago

@girving The PR got updated recently and has a unit test that suggests everything is working as expected. Probably getting near what's acceptable for merger, do you mind having a look?

girving commented 7 years ago

@aidangomez On leave, so someone else will have to review.

tfboyd commented 7 years ago

Closing. The PR is still open. I am not sure why it did not get resolved and the discussion should continue there.