tensorflow / tensorflow

An Open Source Machine Learning Framework for Everyone
https://tensorflow.org
Apache License 2.0
185.69k stars 74.19k forks source link

Feature Request: Sparse Cholesky decomposition #15910

Closed rwolst closed 2 years ago

rwolst commented 6 years ago

System information

Describe the problem

TensorFlow has a Cholesky decomposition kernel based on wrappers around the Eigen and cuSOLVER (for GPUs) libraries.

From experience, a sparse solver can provide huge speedups in the right circumstances. The cuSOLVER library has the feature in their sparse LAPACK library, cuSolverSP, and the Eigen library in the SparseCholesky module.

Alternatively, there is the CHOLMOD library which is supported by Eigen in the CholmodSupport module. This CHOLMOD library supports both CPU and GPU sparse Cholesky factorisations.

Would a Cholesky decomposition for sparse matrices be a feature of interest?

skye commented 6 years ago

@rmlarsen can you comment or redirect? Thanks!

dpmerrell commented 3 years ago

Let me revive this issue (and add something to it):

In the source for SparseMatrixSparseCholesky I see a few contributors. @kiszk @penpornk @bloops I wonder if you have thoughts about the sparse Cholesky decomposition and its gradient?

I have research interests related to this topic and would like to contribute, but I'm finding it difficult to learn TensorFlow's C++ API. I welcome any advice or suggestions.

bloops commented 3 years ago

Sure, @dpmerrell, I can help you with the TensorFlow implementation. Do you have the algorithm ready that you want to implement?

chunduriv commented 2 years ago

@rwolst,

Please check SparseMatrixSparseCholesky. Thanks!

google-ml-butler[bot] commented 2 years ago

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.

google-ml-butler[bot] commented 2 years ago

Closing as stale. Please reopen if you'd like to work on this further.