tensorflow / tfjs

A WebGL accelerated JavaScript library for training and deploying ML models.
https://js.tensorflow.org
Apache License 2.0
18.41k stars 1.92k forks source link

Request to implement correlation layer #1063

Closed zboldyga closed 1 year ago

zboldyga commented 5 years ago

Describe the problem or feature request

A novel correlation layer is introduced in the FlowNet paper: https://arxiv.org/abs/1504.06852. This layer has been implemented in a pull request and it sounds like this will be added to Tensorflow/addons soon:

https://github.com/tensorflow/tensorflow/issues/11956 https://github.com/tensorflow/tensorflow/pull/21392

I am familiar with the mechanics of the correlation layer and recently did work on 3d convolutions in tfjs, I'd be happy to implement the correlation layer in tfjs :)

gaikwadrahul8 commented 1 year ago

Hi, @zboldyga

Apologize for the delayed response and I see this feature request hasn't implemented till now if I'm not wrong so still are you looking to implement this feature in TFJS ? Thank you!

zboldyga commented 1 year ago

@gaikwadrahul8 good timing, I was just about to prowl around for some project & use case to make a contribution. It's been a couple of years since I touched this code, but happy to scope it out, determine the value of this.

Do you know offhand the magnitude of requests for this type of feature, the relevant use cases? If not I can scan the mailing list & issues and revisit the proposed logic to figure out the impact and what implementation would look like

gaikwadrahul8 commented 1 year ago

Hi, @zboldyga

Apologize for the delayed response and just to confirm, are you working on this feature request ? I found one PR https://github.com/tensorflow/addons/pull/207 which may help to work on this feature request. Thank you!

github-actions[bot] commented 1 year ago

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

github-actions[bot] commented 1 year ago

This issue was closed due to lack of activity after being marked stale for past 7 days.