tensorflow / tfjs

A WebGL accelerated JavaScript library for training and deploying ML models.
https://js.tensorflow.org
Apache License 2.0
18.52k stars 1.94k forks source link

`flipHorizontal` option of the `segmentPerson` method in bodyPix doesn't work #6412

Closed obadakhalili closed 2 years ago

obadakhalili commented 2 years ago

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template

System information

Describe the current behavior The segmentPerson method of the bodyPix network doesn't consider the option flipHorizontal.

Describe the expected behavior The image should be flipped horizontally before segmentation based on the boolean value of the flipHorizontal option.

Standalone code to reproduce the issue Provide a reproducible test case that is the bare minimum necessary to generate the problem. If possible, please share a link to Colab/CodePen/any notebook. It's enough to try out the segmentPerson method with different values to see that it is not being considered.

Other info / logs Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. BodyPix version: 2.2.0

rthadur commented 2 years ago

please use new pose-detection model here https://github.com/tensorflow/tfjs-models/tree/master/pose-detection as we no longer support body pix. Thank you

obadakhalili commented 2 years ago

please use new pose-detection model here https://github.com/tensorflow/tfjs-models/tree/master/pose-detection as we no longer support body pix. Thank you

It's weird why this is not mentioned anywhere. I already invested some time in bodyPix ... Also, the main thing I need is the segmentation functionality. Does pose-detection support that?

obadakhalili commented 2 years ago

please use new pose-detection model here https://github.com/tensorflow/tfjs-models/tree/master/pose-detection as we no longer support body pix. Thank you

It's weird why this is not mentioned anywhere. I already invested some time in bodyPix ... Also, the main thing I need is the segmentation functionality. Does pose-detection support that?

It seems like the answer to that question is yes through BlazePose-MediaPipe. Thank you.

rthadur commented 2 years ago

We are in the process of updating the models to reference correct one. Apologies for the inconvenience . Glad it worked for you. Closing this request.

google-ml-butler[bot] commented 2 years ago

Are you satisfied with the resolution of your issue? Yes No