Infrastructure to enable deployment of ML models to low-power resource-constrained embedded targets (including microcontrollers and digital signal processors).
Apache License 2.0
1.74k
stars
769
forks
source link
Remove #definitions of MAX_RFFT_PWR, MIN_RFFT_PWR from Xtensa flags #2577
First, the definition -DMIN_RFFT_PWR=MAX_RFFT_PWR
is meaningless, because MAX_RFFT_PWR doesn't evaluate to a number. That's a bug.
Second, both #definitions are only applicable when building Nature DSP for hifi3 and hifimini. Later archs (hifi4, hifi5) stopped using them. That's confusing to define them for all archs.
Finally, there are a lot of possible #definitions and there's no reason to define these particular two in the main Xtensa makefile. A user can add any #define to XTENSA_EXTRA_CFLAGS.
BUG=340206722
First, the definition -DMIN_RFFT_PWR=MAX_RFFT_PWR is meaningless, because MAX_RFFT_PWR doesn't evaluate to a number. That's a bug. Second, both #definitions are only applicable when building Nature DSP for hifi3 and hifimini. Later archs (hifi4, hifi5) stopped using them. That's confusing to define them for all archs. Finally, there are a lot of possible #definitions and there's no reason to define these particular two in the main Xtensa makefile. A user can add any #define to XTENSA_EXTRA_CFLAGS. BUG=340206722