tensorflow / tflite-micro

Infrastructure to enable deployment of ML models to low-power resource-constrained embedded targets (including microcontrollers and digital signal processors).
Apache License 2.0
1.94k stars 828 forks source link

Add INT32 Support to Sub #2720

Open HemanthSai7 opened 1 month ago

HemanthSai7 commented 1 month ago

When trying to deploy the model on ESP32S3, I get a warning called SUB failed to invoke INT32 not supported. I have fixed it and I want to contribute by opening a PR.

ddavis-2015 commented 1 month ago

@HemanthSai7

TFLM (aka LRTM) welcomes PR contributions! Please submit your PR at your leisure with these rules in mind:

So you would need unit tests in sub_test.cc for INT32 that cover both broadcast and non-broadcast (just like the INT16). Also be aware that if this is your first time submitting code, you will need to sign the CLA. You will be presented with information on how to do this when you submit the PR.

Also, somewhere in the PR description there must be a line bug=#xxxx where xxxx is this issue number.

HemanthSai7 commented 1 month ago

Okay, I will keep these points in mind.

github-actions[bot] commented 1 week ago

"This issue is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

HemanthSai7 commented 6 days ago

This issue is not stale. I will create a PR.