search

tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 64 forks source link

Update examples for feature selection component #116

Closed deutranium closed 2 years ago

deutranium commented 2 years ago

Updated examples for feature selection component, including spliiting the common file and updated the module file structure

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 2 years ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

rcrowe-google commented 2 years ago

Could you fix the conflicts?

deutranium commented 2 years ago

@rcrowe-google done! I think only /merge is left now

rcrowe-google commented 2 years ago

/merge

rcrowe-google commented 2 years ago

@deutranium @Nirzu97 @pratishtha-abrol @FatimahAdwan

The auto-merge needs a comment from an owner (one of you) with /merge on a line by itself

deutranium commented 2 years ago

/merge

deutranium commented 2 years ago

Thanks!

Oh, I think it needs a /merge by one of the other codeowners Cc @FatimahAdwan @pratishtha-abrol @Nirzu97

FatimahAdwan commented 2 years ago

Hi, am finding it a little bit difficult to get to approve this ):

Thanks!

Oh, I think it needs a /merge by one of the other codeowners Cc @FatimahAdwan @pratishtha-abrol @Nirzu97 okay let me check that

github-actions[bot] commented 2 years ago

Merged with approvals from FatimahAdwan and pratishtha-abrol - thanks for the contribution! :tada:

FatimahAdwan commented 2 years ago

Hi, am finding it a little bit difficult to get to approve this ):

Thanks! Oh, I think it needs a /merge by one of the other codeowners Cc @FatimahAdwan @pratishtha-abrol @Nirzu97 okay let me check that

i think is done now, merged or so :)

casassg commented 2 years ago

yup @FatimahAdwan you copying the comment from @deutranium was enough :P as it contains /merge in it

casassg commented 2 years ago

Btw, can we remove stdout from notebooks? It adds a lot of content in the notebook which is not always easy to read. (just press Clear output before saving it)

casassg commented 2 years ago

(also the assumption is correct the bot ignores author /merge request as a way to increase consensus on merging things)