update firebase publisher proposal

tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group

Apache License 2.0

125 stars 64 forks source link

update firebase publisher proposal #171

Closed deep-diver closed 2 years ago

deep-diver commented 2 years ago

update firebase publisher proposal with more detailed descriptions

changes

function based -> class based, since this can be implemented easier by inheriting Pusher
input/outputs information
custom_config to be provided
not only TFLite but also SavedModel is directly supported

I have implemented FirebasePublisher component based on this. Once this is merged, I will immediately create another PR for the code implementation. Please take a look @rcrowe-google, @casassg, @sayakpaul

github-actions[bot] commented 2 years ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

casassg commented 2 years ago

/lgtm lmk when you are ready to merge

deep-diver commented 2 years ago

updated accordingly. removed custom_config. Please review once @casassg

casassg commented 2 years ago

Looks good to me!

You may need @sayakpaul to comment /lgtm and /merge as he is the coowner of the project in order for automatic merging to work. Otherwise I can manually merge (This way we check that you dont need me to merge things :D )

deep-diver commented 2 years ago

@sayakpaul

addressed your comments!

sayakpaul commented 2 years ago

/lgtm /merge

github-actions[bot] commented 2 years ago

Merged with approvals from sayakpaul - thanks for the contribution! :tada: