search

tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 64 forks source link

HFModelPusher component proposal #174

Closed deep-diver closed 2 years ago

deep-diver commented 2 years ago

Wrote a HFModelPusher component proposal (cc: @sayakpaul as the co-developer)

github-actions[bot] commented 2 years ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

deep-diver commented 2 years ago

addressed the comments.

need reviews from @casassg, @rcrowe-google

sayakpaul commented 2 years ago

/lgtm

casassg commented 2 years ago

it will need a /merge from Robert as he is the sole owner XD

codesue commented 2 years ago

/lgtm

deep-diver commented 2 years ago

@casassg

Once this PR is merged, I will make another PR to update this proposal to include HuggingFace Space Deployment feature. Or should I do it now? I want to do it on a separate PR to clearly discuss different concerns.

casassg commented 2 years ago

I think that's fine. I can't merge this due to Robert being owner of the proposals himself (I could merge it but prefer to let him do this as I dont want to force merge either) You may want to tag him on slack next week to double check.

That said, while merging proposal blocks merging the code, you can start opening PRs w the code itself (as long as we merge those after we merge this we should be fine)

deep-diver commented 2 years ago

then I will wait until @rcrowe-google merges this PR :)

casassg commented 2 years ago

Given Robert is out for a couple days, and given he approved this. I will manually merge, to help work continue on this

rcrowe-google commented 2 years ago

Sorry I missed this, and thanks for merging!